[tor-bugs] #22311 [Core Tor/Tor]: authdir_mode_any_nonhidserv() is an obsolete concept

[Tor Bug Tracker & Wiki]

#22311: authdir_mode_any_nonhidserv() is an obsolete concept
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  easy, tor-hs  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  arma          |        Sponsor:
--------------------------+------------------------------------

Comment (by huyvq):

 Replying to [comment:7 arma]:
 > I've also been looking through authdir_mode_publishes_statuses(), which
 looks like it doesn't have to exist anymore and could just be replaced
 with a call to authdir_mode()?

 As I understand, authdir_mode_publishes_statuses() cannot be replaced with
 authdir_mode() since it requires `BridgeAuthoritativeDir == 0 &&
 AuthoritativeDir != 0`. Am I missing something?

 > And the same with authdir_mode_tests_reachability() -- now that all
 types of auths test reachability, I don't think we need a separate wrapper
 function.

 Yes.

 I separated the patch to a series of commits as your comment. Please let
 me know if I could do better :)
 Thanks.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22311#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online