[tor-bugs] #23054 [Core Tor/Tor]: BUG() macros shouldn't be warned as dead-code under coverity.

[Tor Bug Tracker & Wiki]

#23054: BUG() macros shouldn't be warned as dead-code under coverity.
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 It's fine for our BUG() checks to be dead code: they're functionally
 equivalent to nonfatal assertions.  Leaving them in is good defensive
 programming, since they prevent us from introducing bugs later on.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23054>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online