[tor-bugs] #22827 [Core Tor/Tor]: Formalise CollecTor spec for sanitised bridge descriptors and put in torspec

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jul 27 12:16:15 UTC 2017


#22827: Formalise CollecTor spec for sanitised bridge descriptors and put in
torspec
---------------------------------------------+-----------------------------
 Reporter:  isis                             |          Owner:  karsten
     Type:  enhancement                      |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  unspecified
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-spec, tor-docs, tor-bridges  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by iwakeh):

 Looks fine!

 Maybe keep the comment section small by removing all resolved comments,
 like c00, c00a, c01,c01a (actually the entire xslt discussion), c07, c07a.
 c03&c03a could be replaced by a remark that ANTLR is too much overhead for
 the moment.
 Regarding c02, c02a:  There is no list of references in the new html.  If
 that resolves the issue, it could also be removed.

 Minor format issue/nitpick:
 I don't find the choice of `[:n]` very intuitive as operator (and also
 applying it from the right.  Maybe just use a function notation, e.g.,
 `Bn`.  For example:
 `KeyedHash = SHA256(Ipv4Address | Fingerprint | Secret)[:3]` could become
 `KeyedHash = B3(SHA256(Ipv4Address | Fingerprint | Secret))`.

 Shouldn't the additional xslt and awk files used for generating html be
 also added to git?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22827#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list