[tor-bugs] #23030 [Core Tor/Tor]: Review coverity build warnings

[Tor Bug Tracker & Wiki]

#23030: Review coverity build warnings
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Coverity emits a big pile of build warnings because of our BUG macro.
 Let's see if we can fix that.  They look like this:
 {{{
 "/home/torcoverity/src/tor/cov-
 int/emit/totoro.wangafu.net/config/fc74ea42bbd56
           ee35d2b17ca574b8e9b/gcc-config-0/coverity-compiler-compat.h",
 line
           1627: warning #41: expression must have arithmetic or pointer
 type
   #nodef BUG() __coverity_panic__()
 }}}

 Also, there are quite a few of these:
 {{{
 "src/common/util.c", line 1169: warning #1563: function "tor_parse_long"
 not
           emitted, consider modeling it or review parse diagnostics to
 improve
           fidelity
   tor_parse_long(const char *s, int base, long min, long max,
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23030>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online