[tor-bugs] #22979 [Core Tor/Tor]: prop224: Add an introduction point onion key in the descriptor

[Tor Bug Tracker & Wiki]

#22979: prop224: Add an introduction point onion key in the descriptor
---------------------------------------+-----------------------------------
 Reporter:  dgoulet                    |          Owner:  dgoulet
     Type:  enhancement                |         Status:  needs_review
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.2.x-final
Component:  Core Tor/Tor               |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  tor-hs, prop224, tor-spec  |  Actual Points:
Parent ID:  #21888                     |         Points:  0.1
 Reviewer:  asn                        |        Sponsor:  SponsorR-must
---------------------------------------+-----------------------------------

Comment (by dgoulet):

 Replying to [comment:6 asn]:
 > Replying to [comment:5 dgoulet]:
 > > Branch: `ticket22979_032_01`
 > >
 > > It's not that big so let me know if an Oniongit would be needed.
 >
 > LGTM, but two quick questions:
 >
 > a) I assume that `ip->onion_key` will be initialized by the service code
 that is not yet included in the branch. So it's OK that it's not really
 filled with anything on the service-side, right?

 Yes exactly. This is really just the "descriptor subsystem" support for
 decoding and encoding.

 > b) Do we really want to `goto err` if we don't recognize the key type
 when decoding descriptor? Doesn't that influence our forward-compatibility
 that the key type field was supposed to be helping?

 Hmmm yes I think you are right. Then we have the same issue with `enc-
 key`... :S

 Basically, if we don't have "ntor" following it, we should just ignore it
 and move on. See fixup commit `76533e10a`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22979#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online