[tor-bugs] #19871 [Core Tor/Tor]: Crypto operation counters are unused and obsolete

[Tor Bug Tracker & Wiki]

#19871: Crypto operation counters are unused and obsolete
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  isis
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-proposed technnical-debt dead-   |  Actual Points:
  code easy                                      |
Parent ID:                                       |         Points:  0.3
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor3-can
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  new => accepted
 * owner:   => isis
 * milestone:  Tor: unspecified => Tor: 0.3.2.x-final


Comment:

 The only place these statistics are used is at the end of `dumpstats(int
 severity)` where `dump_pk_ops()` is called after getting a SIGUSR1 signal
 (but only if `severity < LOG_INFO`). You're both right that these
 statistics seem a bit useless, because this info is kind of weird info to
 keep around, i.e. I'm not sure why we'd want to know how many times we did
 TLS or how many signatures we verified.  (More seemingly useful info about
 public key operations would be higher-level, e.g. routers we're talking to
 for which some crypto operation has an anomalous failure rate.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19871#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online