[tor-bugs] #22905 [Core Tor/Tor]: Cargo.lock and Cargo.toml specify incompatible dependencies for libc

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jul 12 23:33:26 UTC 2017


#22905: Cargo.lock and Cargo.toml specify incompatible dependencies for libc
-----------------------------+--------------------------
 Reporter:  isis             |          Owner:
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  rust, tor-build  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:  SponsorZ
-----------------------------+--------------------------

Comment (by isis):

 There are two fixes as far as I can tell for this:

 1) Don't commit `Cargo.lock` files (see #22906)
 2) Change `src/rust/tor_util/Cargo.toml` to specify `libc = "0.2.22"`
 ([http://doc.crates.io/faq.html#can-libraries-use--as-a-version-for-their-
 dependencies the Cargo docs] say to never use `"*"` and additionally
 anything which does this is automatically rejected from crates.io)

 Alternatively, for !#2, we could specify `libc = "^0.2"` which would grab
 the highest numbered thing >=0.2 and <0.3, but we might want to have a
 discussion about what that could do to reproducible builds.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22905#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list