[tor-bugs] #22789 [Core Tor/Tor]: Tor 0.3.1.4-alpha crash on OpenBSD-current

[Tor Bug Tracker & Wiki]

#22789: Tor 0.3.1.4-alpha crash on OpenBSD-current
-------------------------------------------------+-------------------------
 Reporter:  fredzupy                             |          Owner:  nickm
     Type:  defect                               |         Status:  closed
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.4-alpha
 Severity:  Major                                |     Resolution:  fixed
 Keywords:  tor, crash, inet_pton, c99,          |  Actual Points:  3
  openbsd, 024-backport, 025-backport,           |
  026-backport, 027-backport, 028-backport,      |
  029-backport, 030-backport, review-group-20    |
  trove-2017-007                                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * keywords:
     tor, crash, inet_pton, c99, openbsd, 024-backport, 025-backport,
     026-backport, 027-backport, 028-backport, 029-backport, 030-backport,
     review-group-20
     =>
     tor, crash, inet_pton, c99, openbsd, 024-backport, 025-backport,
     026-backport, 027-backport, 028-backport, 029-backport, 030-backport,
     review-group-20 trove-2017-007
 * status:  merge_ready => closed
 * resolution:   => fixed
 * actualpoints:   => 3


Comment:

 Thanks for the review!  Merged to 0.2.4 and forward.

 If anybody wants to ask the OpenBSD Libc maintainers what they think about
 the standard here, they should feel free to do so politely.  Apparently
 OpenBSD inherited the code from NetBSD, which may also have the same
 behavior.  FreeBSD appears to have patched itself to have the behavior
 that Tor expects.

 I'll refrain from any arguments about whether the standard permits this
 behavior; even if it doesn't, the behavior apparently exists in the wild,
 so Tor has to work around it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22789#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online