[tor-bugs] #22805 [Core Tor/Tor]: Remove or_circuit_t.is_first_hop, because it's not accurate any more

[Tor Bug Tracker & Wiki]

#22805: Remove or_circuit_t.is_first_hop, because it's not accurate any more
-----------------------------+---------------------------------------------
     Reporter:  teor         |      Owner:
         Type:  defect       |     Status:  new
     Priority:  Medium       |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core         |    Version:
  Tor/Tor                    |
     Severity:  Normal       |   Keywords:  technical-debt, security-review
Actual Points:               |  Parent ID:
       Points:  1            |   Reviewer:
      Sponsor:               |
-----------------------------+---------------------------------------------
 Tor relays set or_circuit_t.is_first_hop when a client uses CREATE_FAST.
 But recent tor clients only use CREATE_FAST when they don't know a relay's
 onion key.

 So we need to replace this with channel_is_client().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22805>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online