[tor-bugs] #20761 [Applications/Tor Launcher]: Tor Browser 6.5a4 is ignoring additional SocksPorts

[Tor Bug Tracker & Wiki]

#20761: Tor Browser 6.5a4 is ignoring additional SocksPorts
---------------------------------------+--------------------------
 Reporter:  gk                         |          Owner:  mcs
     Type:  defect                     |         Status:  assigned
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  TorBrowserTeam201701R      |  Actual Points:
Parent ID:                             |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+--------------------------
Changes (by mcs):

 * keywords:  TorBrowserTeam201701 => TorBrowserTeam201701R


Comment:

 Now that the fix for #20956 has landed, we can proceed with Tor Launcher
 changes that take advantage of it. Here are two patches for review (the
 tor-browser-bundle patch removes the SocksPort and ControlPort lines from
 torrc-defaults to avoid conflcts with what Tor Launcher does):

 https://gitweb.torproject.org/user/brade/tor-browser-
 bundle.git/commit/?h=bug20761-02&id=5c44ae3568b9f42fcebb8426d567c0311c4c9b19

 https://gitweb.torproject.org/user/brade/tor-
 launcher.git/commit/?h=bug20761-02&id=5060eb48b7fd401264888ccef1876f647daeb494

 There is still one open issue: some current alpha users have SocksPort and
 ControlPort lines in their torrc that are there because tor wrote them
 (due to a SAVECONF). After an upgrade, lines will likely cause conflicts
 with the ports that the new Tor Launcher will add. Do we need to clean
 these up for people or is it acceptable to cause pain for alpha users?
 (manual edit of torrc required)

 It seems like we may want to try to clean them up, but to do that we need
 to add code to Tor Launcher that runs once and tries to delete the
 offending lines from torrc.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20761#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online