[tor-bugs] #21266 [Core Tor/Tor]: test: Improve hs intropoints unit test with expected msg log.

[Tor Bug Tracker & Wiki]

#21266: test: Improve hs intropoints unit test with expected msg log.
-----------------------------------------+---------------------------------
 Reporter:  dgoulet                      |          Owner:  ahf
     Type:  enhancement                  |         Status:  assigned
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.0.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  test, tor-hs, prop224, easy  |  Actual Points:
Parent ID:  #12424                       |         Points:
 Reviewer:                               |        Sponsor:  SponsorR-must
-----------------------------------------+---------------------------------

Comment (by asn):

 The idea of this ticket is to enrich the tests at
 `src/test/test_hs_intropoint.c` by making them test more failure cases.
 Also, in the failure case tests we should use the `expect_log_msg()` test
 utility function to make sure that we actually fail in the right codepath.

 To get an idea of which failure cases are not handled, run the tests with
 code coverage enabled (see `doc/HACKING/HelpfulTools.md`) and see which
 code paths are never taken.

 Finally, let's not spend too much time here. We can probably surive
 without testing 100% of all the failure cases.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21266#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online