[tor-bugs] #21280 [Core Tor/Tor]: tor-resolve: Do not truncate too long hostnames

[Tor Bug Tracker & Wiki]

#21280: tor-resolve: Do not truncate too long hostnames
-------------------------------------------------+-------------------------
 Reporter:  junglefowl                           |          Owner:
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.8
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-resolve, security-review,        |  Actual Points:
  029-backport                                   |
Parent ID:                                       |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  tor-resolve => tor-resolve, security-review, 029-backport
 * status:  new => needs_revision
 * points:   => 0.5
 * milestone:   => Tor: 0.3.0.x-final


Comment:

 Replying to [comment:1 cypherpunks]:
 > I suggest using `UINT8_MAX` instead of a magic number.

 256 is `UINT8_MAX + 1`.

 Putting this in 0.3.0, because truncating inputs and substituting part of
 a string for a port number is problematic.

 This could be a security issue if tor-resolve is used on untrusted inputs.

 This might be worth doing an 0.2.9 backport, but I'm not sure if we want
 to do one to 0.2.8.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21280#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online