[tor-bugs] #20956 [Core Tor/Tor]: optionally do not write command line config to torrc

[Tor Bug Tracker & Wiki]

#20956: optionally do not write command line config to torrc
------------------------------------+------------------------------------
 Reporter:  mcs                     |          Owner:  nickm
     Type:  enhancement             |         Status:  needs_review
 Priority:  Medium                  |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor            |        Version:
 Severity:  Normal                  |     Resolution:
 Keywords:  tbb-wants 029-backport  |  Actual Points:  .2
Parent ID:                          |         Points:  2
 Reviewer:                          |        Sponsor:
------------------------------------+------------------------------------

Comment (by mcs):

 This seems to work, at least for the scenarios that Kathy and I tested
 (thanks Nick!).

 We modified Tor Launcher to pass `+__ControlPort` and `+__SocksPort` as
 args when starting tor.
 We also removed the default `ControlPort` and `SocksPort` lines from the
 `torrc-defaults` file that ships with Tor Browser.

 With Nick's tor changes plus these Tor Launcher changes, there is no
 longer any interference with any additional control or SOCKS ports that
 users might add to their torrc. Duplicates need to be avoided though;
 otherwise tor will not start up (I think that is okay).

 The original Tor Launcher ticket is #20761.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20956#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online