[tor-bugs] #12685 [Metrics/Atlas]: Wrap fingerprint line on smaller displays

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jan 19 20:01:59 UTC 2017


#12685: Wrap fingerprint line on smaller displays
----------------------------------+--------------------------
 Reporter:  Zitlo                 |          Owner:  RaBe
     Type:  defect                |         Status:  assigned
 Priority:  Very Low              |      Milestone:
Component:  Metrics/Atlas         |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  visibility of uptime  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+--------------------------
Changes (by irl):

 * status:  needs_review => assigned
 * owner:  irl => RaBe


Comment:

 This change shouldn't be happening in the model, but in the view. It's not
 changing a property of the data but a property of the presentation. By
 changing it in the model it breaks generated URLs. You'll see that in the
 "Top 10" page, none of those links are usable as the URLs are generated
 from the fingerprint in the model and you end up with links like:

 index.html#details/81B75D534F91BFB7C57A%E2%80%8BB67DA10BCEF622582AE8%E2%80%8B

 Just for fun, by the time it gets to being a link it's also been URL
 encoded.

 Looks like the right fix, but not in the right place.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12685#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list