[tor-bugs] #20981 [Applications/Tor Browser]: The localized date string on Windows reveals local time

[Tor Bug Tracker & Wiki]

#20981: The localized date string on Windows reveals local time
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  arthuredelstein
     Type:  defect                               |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:  fixed
 Keywords:  tbb-fingerinting, tbb-regression,    |  Actual Points:
  tbb-6.0-issues, TorBrowserTeam201701R          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:10 arthuredelstein]:
 > I believe the malloc'd memory is necessary -- later code attempts to
 free it if I recall correctly.

 Yes, in `timezone.cpp`:
 {{{
 #if U_PLATFORM_USES_ONLY_WIN32_API
     // hostID points to a heap-allocated location on Windows.
     uprv_free(const_cast<char *>(hostID));
 #endif
 }}}

 Looks good to me. I tested the patch on a Windows machine and the issue is
 fixed with it.

 Applied to `tor-browser-45.6.0esr-6.5-1` (commit
 025f08062d4e633432e0248bbd047ac5d61c4399). I guess this can make it into
 6.5 as the patch is quite simple.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20981#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online