[tor-bugs] #20852 [Core Tor/Tor]: prop224: Update HSDir prop224 code based on newest descriptor changes

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jan 9 13:02:11 UTC 2017


#20852: prop224: Update HSDir prop224 code based on newest descriptor changes
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  asn
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, TorCoreTeam201612,  |  Actual Points:
  review-group-14                                |
Parent ID:                                       |         Points:  3
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_review => merge_ready


Comment:

 The `INT32_MAX` is OK with me as cast to an `unsigned int` should not
 overflow. And if your arch considers a `int` to be 2 bytes, well we'll hit
 the maximum which is ok.

 lgtm!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20852#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list