[tor-bugs] #21159 [Core Tor/Tor]: Superfluous Include Statement

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Jan 6 22:51:21 UTC 2017


#21159: Superfluous Include Statement
--------------------------------+-----------------
     Reporter:  BenjaminPollak  |      Owner:
         Type:  enhancement     |     Status:  new
     Priority:  Very Low        |  Milestone:
    Component:  Core Tor/Tor    |    Version:
     Severity:  Trivial         |   Keywords:
Actual Points:                  |  Parent ID:
       Points:                  |   Reviewer:
      Sponsor:                  |
--------------------------------+-----------------
 Hi all,

 I think the code in /src/test/test_bt_cl.c could be improved by removing
 line 4, which reads:
 {{{#include "orconfig.h"}}}
 because line 11 of /src/test/test_bt_cl.c reads:
 {{{#include "util.h"}}}
 I checked util.h (found in /src/common/), and it already includes the
 orconfig.h file on line 14.

 Would it be appropriate then, to delete line 4 of /src/test/test_bt_cl.c?

 Thanks,
 Benjamin

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21159>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list