[tor-bugs] #10972 [Metrics/Onionoo]: searching atlas for email addresses fails

[Tor Bug Tracker & Wiki]

#10972: searching atlas for email addresses fails
-----------------------------+------------------------------
 Reporter:  cypherpunks      |          Owner:  phw
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review
 * cc: iwakeh (added)
 * component:  Metrics/Atlas => Metrics/Onionoo
 * severity:   => Normal


Comment:

 This issue is unrelated to Atlas and is in fact an Onionoo issue.  The
 query that phw mentions,
 `https://onionoo.torproject.org/summary?contact=user@domain.com` works
 just fine, but Atlas does not (and should not) pass its search string to
 Onionoo via the `contact` parameter.  Atlas should instead pass everything
 it gets from the user to the `search` parameter.

 Here's how this is supposed to work as of Onionoo protocol version 1.2,
 which was published in October 2014, half a year after this ticket was
 opened: Atlas users would use a qualified search term like
 `contact:user at domain.com` to search by contact.

 However, and here's the bug, Onionoo's `search` parameter check is more
 restrictive than its `search` parameter.  For example, the `contact`
 parameter accepts the `@` character as input just fine, but the `search`
 parameter responds with 400 Bad Request.  We should fix this, and then
 Atlas users can search by contact email address.

 Please review
 [https://gitweb.torproject.org/user/karsten/onionoo.git/log/?h=task-10972
 my Onionoo branch task-10972].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10972#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online