[tor-bugs] #21150 [Core Tor/Tor]: HiddenServiceStatistics gets set to 0 in your torrc, and stays 0 when you become a relay

[Tor Bug Tracker & Wiki]

#21150: HiddenServiceStatistics gets set to 0 in your torrc, and stays 0 when you
become a relay
------------------------------+-----------------
     Reporter:  arma          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+-----------------
 HiddenServiceStatistics defaults to 1:
 {{{
   V(HiddenServiceStatistics,     BOOL,     "1"),
 }}}
 but if you're not a public relay, it gets set to 0 on startup:
 {{{
     if (!public_server_mode(options)) {
       options->CellStatistics = 0;
       options->EntryStatistics = 0;
       options->ConnDirectionStatistics = 0;
       options->HiddenServiceStatistics = 0;
       options->ExitPortStatistics = 0;
     }
 }}}
 and then when you saveconf, it doesn't match the default so you get a new
 line in your torrc file:
 {{{
 HiddenServiceStatistics 0
 }}}

 And then later if you run your Tor as a relay, it looks at the torrc file
 and decides not to collect or report hiddenservicestatistics, which is bad
 because that's supposed to be the default.

 I think the fix is that we need an internal variable which reflects what
 we've decided to do, and we need to stop modifying the config option in
 place.

 The same issue happened in #4244, and I think we have some other recent
 tickets to make this change for other config options.

 This ticket would resolve #17909 as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21150>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online