[tor-bugs] #21054 [Core Tor/Tor]: hs: BUG() is triggered with ephemeral service on config reload

[Tor Bug Tracker & Wiki]

#21054: hs: BUG() is triggered with ephemeral service on config reload
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, prop224, refactoring,        |  Actual Points:
  review-group-14                                |
Parent ID:                                       |         Points:  0.5
 Reviewer:  asn                                  |        Sponsor:
                                                 |  SponsorR-can
-------------------------------------------------+-------------------------

Comment (by asn):

 Initial review:

 Changes look reasonable to me. One question, why does
 `circuit_get_next_service_intro_circ()` need the `start` argument?

 In the old code, we just iterated from the beginning of the circuitlist
 everytime. Why do we now begin from `start`? Is it an optimization?

 Also, BTW I didn't manage to reproduce the original bug. How do we do it?
 I started up a Tor with a normal HS, then I added an ADD_ONION, and then I
 HUPed. Am I missing a step?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21054#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online