[tor-bugs] #20596 [Metrics]: streamline build.xml and metrics_checkstyle.xml throughout all java projects

[Tor Bug Tracker & Wiki]

#20596: streamline build.xml and metrics_checkstyle.xml throughout all java
projects
-------------------------+--------------------------------
 Reporter:  iwakeh       |          Owner:  iwakeh
     Type:  enhancement  |         Status:  needs_revision
 Priority:  Medium       |      Milestone:
Component:  Metrics      |        Version:
 Severity:  Normal       |     Resolution:
 Keywords:               |  Actual Points:
Parent ID:               |         Points:
 Reviewer:               |        Sponsor:
-------------------------+--------------------------------

Comment (by iwakeh):

 Replying to [comment:31 karsten]:
 > Okay, here's what I did and where I ran into issues:
 >
 >  - Pushed your two metrics-base patches to
 [https://gitweb.torproject.org/metrics-base.git/ metrics-base] without
 changes.
 >
 >  - Tried running `ant tar` in your
 [https://gitweb.torproject.org/user/iwakeh/onionoo.git/log/?h=task-20596-submod
 onionoo task-20596-submod branch], but it keeps telling me that signing of
 at least one of the .jars failed.  I didn't investigate further yet.  Does
 that work for you?

 That worked fine in the test setting I had, well. I'll look into it.

 >
 >  - Rebased your [https://gitweb.torproject.org/user/iwakeh/metrics-
 lib.git/log/?h=task-20596-submod metrics-lib task-20596-submod branch] and
 pushed it to [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/log/?h=task-20596 branch task-20596 in my repository].  (Though
 I'm planning to squash your squash commit into "Implements task-20596"
 rather than "Added development description" when merging to master.)
 Realized that Gson is indeed unhappy, so we should keep your commit, but
 without explicit null-initializations, if possible.  However, I ran into
 two issues:
 >      - The sources jar contains sources in a different place than
 previous tarballs.
 >      - The executable jar contains other classes than just our own,
 which it shouldn't (as opposed to the other executable jars).
 >
 >  - Rebased your
 [https://gitweb.torproject.org/user/iwakeh/collector.git/log/?h=task-20596-submod
 collector task-20596-submod branch] and pushed it to
 [https://gitweb.torproject.org/karsten/metrics-db.git/log/?h=task-20596
 branch task-20596 in my repository].  Building seems to work fine, but I
 found this warning: "[javadoc] javadoc: error - Error while reading file
 /Users/karsten/src/collector/src/main/resources/overview.html".  I didn't
 compare .jar file contents yet but expect to find similar differences as I
 found in the metrics-lib .jar files.  Same goes for Onionoo above.
 >
 > Would you want to look into some of these issues?  I can do another
 round of tests and checks tomorrow.  Thanks!

 No problem, I'll take a look at all the issues.  Thanks for checking
 quickly!

 Could you specify the source location differences?
 And, (without knowing how weird the paths might be) is the new path
 structure problematic?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20596#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online