[tor-bugs] #20625 [Core Tor/Tor]: When a consensus doesn't have enough signatures, write it (and sigs) to a file

[Tor Bug Tracker & Wiki]

#20625: When a consensus doesn't have enough signatures, write it (and sigs) to a
file
-----------------------------+------------------------------------
 Reporter:  teor             |          Owner:
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  easy?, tor-auth  |  Actual Points:
Parent ID:                   |         Points:  1
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 Hi jvsg, thanks for this patch!

 I'm not sure if this is the code you meant to submit: as far as I can see,
 it reads the file "cached-[<flavour>-]consensus", rather than writing the
 file "unpublished-consensus".

 Also, you will need to add both "unpublished-consensus" and "unpublished-
 microdesc-consensus" to the sandbox whitelist.

 It also looks like you might have copied this code from somewhere.
 If so, we try to refactor code into a static function and call it from
 multiple locations, rather than copying it. (If not, use tor_asprintf()
 rather than tor_snprintf(), it's much easier!)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20625#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online