[tor-bugs] #21059 [Core Tor/Tor]: shared-rand-current-value violates spec

[Tor Bug Tracker & Wiki]

#21059: shared-rand-current-value violates spec
--------------------------+------------------------------------
 Reporter:  atagar        |          Owner:  asn
     Type:  defect        |         Status:  closed
 Priority:  High          |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Major         |     Resolution:  fixed
 Keywords:                |  Actual Points:
Parent ID:                |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by atagar):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 Oh for the love of... flag-thresholds is also in the wrong spot. That one
 was added way back in 2013 but in Stem I coded against tor's actual
 behavior rather than the spec causing it to go under the radar. Fixed.

 Spec ordering with regard to this is clearly error prone enough that I'm
 gonna change this from a MUST clause to SHOULD. Changes pushed...

 https://gitweb.torproject.org/torspec.git/commit/?id=578477a6af99ec1e4a501e267a563730519ffc0f

 As such Stem will no longer check the ordering of these fields. Tor will
 drift further from the spec here once we drop these checks but I don't
 think this is a detail any of us are gonna lose sleep over. :)

 Feel free to reopen if you'd care to go a different course with this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21059#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online