[tor-bugs] #21459 [Metrics/Atlas]: Make atlas fingerprint selectable by double-clicking

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Feb 28 21:00:59 UTC 2017


#21459: Make atlas fingerprint selectable by double-clicking
---------------------------+------------------------------
 Reporter:  teor           |          Owner:  irl
     Type:  defect         |         Status:  needs_review
 Priority:  Medium         |      Milestone:
Component:  Metrics/Atlas  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:  regression     |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+------------------------------

Comment (by cypherpunks):

 Replying to [comment:5 RaBe]:
 > We still need the fingerprint class to adjust the DDs margin, but I
 agree keeping it as a DD might be the better way :) Also I removed the
 trailing spaces.
 >
 >
 https://github.com/RaphaelBergmann/atlas/commit/0a8aefbe54968e2e6aa302ad4dad4762c7ad77f6
 I don't see why the margins of the fingerprint field should be altered. It
 requires custom code (which need to be maintained) and makes the look of
 the fingerprint inconsistent with other fields that use `<pre>`. Trying to
 get the fingerprint to use a single line is an unreachable goal because
 you don't know the sizes of all the viewports that are used. (For
 instance, on my end your branch still doesn't make the fingerprint use a
 single line because of the viewport i use).

 The other changes look good.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21459#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list