[tor-bugs] #21511 [Core Tor/Tor]: State.tmp is not erased and it may contain sensitive information

[Tor Bug Tracker & Wiki]

#21511: State.tmp is not erased and it may contain sensitive information
--------------------------+-----------------------------------
 Reporter:  ric_sm        |          Owner:
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+-----------------------------------
Changes (by dgoulet):

 * status:  assigned => needs_information


Comment:

 Yes we do...

 {{{
     /* We always replace an existing temporary file if there is one. */
     open_flags |= O_CREAT|O_TRUNC;
 }}}

 So I think this can only be caused by clausing the Tor Browser abruptly at
 the exact time where the temp file existed but then it will get
 overwritten later on. The other possibility is that something went wrong
 with the rename() and then for some other reason the unlink() that we try
 to do on the temp file if the rename did fail. In that case, the log
 should have warnings.

 @ric_sm, maybe you can open your Tor Browser in the console and look for
 those warnings?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21511#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online