[tor-bugs] #21334 [Core Tor/Tor]: prop224: Update prop224 HS desriptor generation code to produce the latest descriptor format

[Tor Bug Tracker & Wiki]

#21334: prop224: Update prop224 HS desriptor generation code to produce the latest
descriptor format
----------------------------------------------+----------------------------
 Reporter:  asn                               |          Owner:
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Very High                         |      Milestone:  Tor:
                                              |  0.3.1.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tor-hs, prop224, review-group-16  |  Actual Points:
Parent ID:                                    |         Points:  3
 Reviewer:  dgoulet                           |        Sponsor:
----------------------------------------------+----------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 Aight. Thanks for the great review.

 All things should be fixed now and I pushed the fixups in my gitlab
 `bug21334_v1`.

 The unittest memory leaks and problems are also fixed in commits `4b9aa38`
 and `88a0f3c`.

 Let me know if there is anything else to be done here, otherwise im gonna
 squash everything nicely, put it in `bug21334_v2` and wait for Nick's
 eyes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21334#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online