[tor-bugs] #21508 [Core Tor/Tor]: POSIX and Windows may interpret directory document whitespace differently

[Tor Bug Tracker & Wiki]

#21508: POSIX and Windows may interpret directory document whitespace differently
------------------------------+------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  parsing
Actual Points:                |  Parent ID:
       Points:  2             |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 on Windows, _atoi64 defines whitespace as:
   A whitespace consists of space or tab characters
 https://msdn.microsoft.com/en-us/library/czcad93k.aspx

 But on POSIX-derived platforms, stroul* define whitespace as isspace(),
 which is:
   \t \n \v \f \r " "

 This affects at least tor_parse_uint64, and perhaps other functions.

 It could mean that some numbers are interpreted differently by Windows and
 POSIX platforms, but since dir-spec.txt defines whitespace as space or
 tab, this is unlikely.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21508>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online