[tor-bugs] #21507 [Core Tor/Tor]: Reject Tor versions that contain non-numeric prefixes

[Tor Bug Tracker & Wiki]

#21507: Reject Tor versions that contain non-numeric prefixes
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.0.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:  0.2           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In #21450, we made tor_version_parse use:
 {{{
 tor_parse_uint64(... , 10, 0, INT32_MAX, ...);
 }}}

 But this still allows versions that start with:
   an arbitrary amount of white space (as determined by isspace(3))
 followed by a single optional "+" or "-" sign

 This doesn't fit the version spec, and we should fix it.
 This is an issue that's existed since we started parsing tor versions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21507>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online