[tor-bugs] #21454 [Core Tor/Tor]: tor_version_compare and version spec comparison order are inconsistent

[Tor Bug Tracker & Wiki]

#21454: tor_version_compare and version spec comparison order are inconsistent
------------------------------+------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-spec
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 Similar to #21449, when we compare versions, we compare the status before
 the patchlevel, and then compare status tag and SCM information.

 But the spec says:
 {{{
 1. The Old Way
 ...
 We compare the elements in order (major, minor, micro, status, patchlevel,
 cvs)
 ...
 2. The New Way
 ...
 MAJOR, MINOR, MICRO, and PATCHLEVEL are numbers
 ...
 All versions should be distinguishable purely by those four numbers.

 The STATUS_TAG is purely informational
 ...
 If we *do* encounter two versions that differ only by status tag, we
 compare them lexically
 ...
 }}}

 This doesn't matter much at the moment because we don't use patchlevels.

 But we should fix this issue, probably by modifying the spec.

 Reported by arma.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21454>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online