[tor-bugs] #21449 [Core Tor/Tor]: Make tor version parsing and version spec consistent
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Feb 14 01:31:38 UTC 2017
#21449: Make tor version parsing and version spec consistent
--------------------------+----------------------------------
Reporter: teor | Owner:
Type: defect | Status: new
Priority: Medium | Milestone: Tor: unspecified
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: tor-spec | Actual Points:
Parent ID: | Points: 2
Reviewer: | Sponsor:
--------------------------+----------------------------------
Comment (by teor):
Here's how to do an equality check right:
(Every check must be a range check, not an equality check.)
https://trac.torproject.org/projects/tor/ticket/20509#comment:39
https://trac.torproject.org/projects/tor/ticket/20509#comment:40
I think all the current tor code is ok, but it's easy to mess up these
comparisons.
We should add a comment to tor_version_compare() recommending using
!tor_version_as_new_as(next version) or tor_version_same_series(), to
avoid the git tag issue.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21449#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list