[tor-bugs] #21278 [Core Tor/Tor]: Avoid signed integer underflow when comparing versions (Fix TROVE-2017-001)

[Tor Bug Tracker & Wiki]

#21278: Avoid signed integer underflow when comparing versions (Fix TROVE-2017-001)
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  029-backport  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 0a2abb3780:

 The function comment change does not describe what the function now does:
 it only returns 0 or 1. And it says "renturn".

 4e720ad736:

 else has an extra space in:

 {{{
 +  if (a->git_tag_len)
 +     return fast_memcmp(a->git_tag, b->git_tag, a->git_tag_len);
 +   else
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21278#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online