[tor-bugs] #21201 [Applications/Tor Browser]: Adapt torbutton to TBB/FF52ESR

[Tor Bug Tracker & Wiki]

#21201: Adapt torbutton to TBB/FF52ESR
-------------------------------------------------+-------------------------
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton,ff52-esr,              |  Actual Points:
  TorBrowserTeam201702                           |
Parent ID:  #20680                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4
-------------------------------------------------+-------------------------

Comment (by arthuredelstein):

 Replying to [comment:3 mcs]:
 > Kathy and I also noticed that the circuit display code triggers a crash
 in our debug build when e10s is enabled. This happens because GetProxyInfo
 is not implemented by HttpChannelChild (the
 getSOCKSCredentialsForBrowser() function tries to access
 `channel.proxyInfo`; on the browser side, see:
 https://github.com/arthuredelstein/tor-
 browser/blob/20680%2B2/netwerk/protocol/http/HttpChannelChild.cpp#L2395).
 >
 > Should I file a new ticket for this issue or will it be covered by this
 ticket?

 I will look into this here and if turns into a big issue I can open a new
 ticket.

 > Also, here is a related question: should we make this the parent bug for
 #21267 and #21268 or do we want to track e10s issues separately?

 Seems reasonable to make this the parent bug.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21201#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online