[tor-bugs] #24742 [Core Tor/Fallback Scripts]: Add fallback list spec to torspec

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 27 18:04:16 UTC 2017


#24742: Add fallback list spec to torspec
---------------------------------------+-----------------------------------
 Reporter:  teor                       |          Owner:  teor
     Type:  enhancement                |         Status:  merge_ready
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  fallback, torspec          |  Actual Points:  1.0
Parent ID:  #24725                     |         Points:  0.5
 Reviewer:  atagar                     |        Sponsor:
---------------------------------------+-----------------------------------
Changes (by atagar):

 * status:  needs_review => merge_ready


Comment:

 Thanks Tim, looks great to me! I can merge spec additions like this if
 you'd like, but since you indicated wanting Nick's review too leaving it
 be.

 [[BR]]

 > The script just outputs whatever Onionoo provides, so we're stuck with
 that

 Oh, I didn't realize fallback generation used Onionoo. Why is that? I
 assume you use the additional data Onionoo provides (geoip and AS)?
 Otherwise seems simpler to just run through descriptors from the dirauths.

 [[BR]]

 > WS (whitespace)

 WS is defined in the dir-spec as...

 {{{
 WS = (SP | TAB)+
 }}}

 Generally the dir-spec and control-spec only use SP. Are you sure you want
 parsers to look for tabs too?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24742#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list