[tor-bugs] #24501 [Core Tor/Tor]: When we hit MaxMemInQueues, make the log message more quantitative

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Dec 25 11:38:26 UTC 2017


#24501: When we hit MaxMemInQueues, make the log message more quantitative
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  needs_revision
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by ffmancera):

 I have been looking at tests and I noticed that we already have a unit
 test for `cell_queues_check_size()` when we are oom on
 `src/test/test_oom.c:161` and  we are calling `circuits_handle_oom()` on
 `src/or/relay.c:2566.`

 So I think that we are already testing if %zu works and for me it works
 well.

 Another thing -- I added cell_queues_get_total_allocation() on log message
 as discussed in #tor-dev.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24501#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list