[tor-bugs] #24677 [Core Tor/Tor]: Use ping ::1 on Linux when ping6 ::1 fails

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Dec 24 15:17:59 UTC 2017


#24677: Use ping ::1 on Linux when ping6 ::1 fails
----------------------------------+------------------------------------
 Reporter:  teor                  |          Owner:  (none)
     Type:  defect                |         Status:  merge_ready
 Priority:  Medium                |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor          |        Version:  Tor: 0.2.9.3-alpha
 Severity:  Normal                |     Resolution:
 Keywords:  easy intro test ipv6  |  Actual Points:
Parent ID:                        |         Points:  0.2
 Reviewer:  teor                  |        Sponsor:
----------------------------------+------------------------------------

Comment (by teor):

 Replying to [comment:6 ffmancera]:
 > I wanted to add your commit on my branch but I wasn't able to.

 It's ok, I don't mind.

 But next time, try:
 {{{
 git remote add teor https://github.com/teor2345/tor.git
 git fetch teor
 git cherry-pick teor/bug24677
 }}}

 Also, in future, adding extra commits for each review helps us review
 faster, because it's easier to see what has changed.

 > So I make the comment changes on my commit if you can give me a patch
 file of the commit I will add it :-).
 >
 > All changes are in my github
 [https://github.com/ffmancera/tor/tree/github/bug24677 branch bug24677]

 Thanks for the update!

 I'm not sure if nickm will mind that you used "Minor features" on a bugfix
 ticket.
 I'll leave that up to him.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24677#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list