[tor-bugs] #23873 [Core Tor/Tor]: Remove the return value of node_get_prim_orport() (was: Tor often forgets to check the return value of node_get_prim_orport())

[Tor Bug Tracker & Wiki]

#23873: Remove the return value of node_get_prim_orport()
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  defect          |         Status:  new
 Priority:  Medium          |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:  #24403          |         Points:  1
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Old description:

> Also, we don't clear the address and port when we fail.
>
> This probably doesn't matter right now, but it matters as soon as we try
> to change node_get_prim_orport().

New description:

 ~~Also, we don't clear the address and port when we fail.~~

 ~~This probably doesn't matter right now, but it matters as soon as we try
 to change node_get_prim_orport().~~

 We don't check it, so let's remove it, and check for the null address
 instead.

--

Comment (by teor):

 #23874 unconditionally clears the address, so all that is left here is to
 remove the return value.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23873#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online