[tor-bugs] #24573 [Core Tor/Tor]: rewrite_node_address_for_bridge() should set IPv6 preferences even if there is no ri

[Tor Bug Tracker & Wiki]

#24573: rewrite_node_address_for_bridge()  should set IPv6 preferences even if
there is no ri
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.4.5-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  ipv6, tor-bridge-client, easy,       |  Actual Points:
  intro                                          |
Parent ID:  #20916                               |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 Code Structure:

 This patch duplicates some code, we should get rid of the duplication when
 we make ri and rs read-only in node_t.

 Backporting:

 Using a relay as a bridge is a rare case, and the configured address will
 only be different for PTs or multi-port or multi-homed relays. I don't
 think we need to backport this.

 Testing:

 The code passes `make check test-network-all`.

 Nitpicks:

 There is a space at the end of the changes file line:
 {{{
 router information or router status and warns about them.
 }}}

 The changes file syntax for bugs is slightly different, it references the
 tor version that the bug was introduced in.

 Please make these two changes file fixes, and flip to merge_ready.

 Also, feel free to credit yourself in the changes file using "Patch by
 (preferred name or handle)".

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24573#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online