[tor-bugs] #24714 [Core Tor/Tor]: rename conn->timestamp_lastwritten to conn->timestamp_lastwritable

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 22 15:29:31 UTC 2017


#24714: rename conn->timestamp_lastwritten to conn->timestamp_lastwritable
------------------------------+--------------------------------
     Reporter:  arma          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 "lastwritten" sure sounds like we actually flushed something or we
 actually added a new thing to write.

 But actually,
 {{{
   time_t timestamp_lastwritten; /**< When was the last time libevent said
 we
                                  * could write? */
 }}}

 It seems that we changed our definition of this word somewhere along the
 line, but we left the old word in place. How confusing.

 We might want to change lastread to lastreadable too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24714>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list