[tor-bugs] #24679 [Core Tor/Fallback Scripts]: Remove weights in the fallback list

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Dec 22 11:51:12 UTC 2017


#24679: Remove weights in the fallback list
---------------------------------------+-----------------------------------
 Reporter:  teor                       |          Owner:  teor
     Type:  enhancement                |         Status:  assigned
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.3.x-final
Component:  Core Tor/Fallback Scripts  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:  fallback                   |  Actual Points:  0.2
Parent ID:  #22271                     |         Points:  0.1
 Reviewer:                             |        Sponsor:  Sponsor8-can
---------------------------------------+-----------------------------------
Changes (by teor):

 * keywords:  fallback easy intro => fallback
 * owner:  (none) => teor
 * status:  needs_revision => assigned
 * type:  defect => enhancement
 * actualpoints:   => 0.2


Comment:

 Hi minik, thanks for your help with this patch, but we decided to remove
 the weights line entirely. I'm going to do it along with #24600 and
 #22759, which also change the file format.

 Pastly, I was wrong about the 1% saving on binary size for the 10 to 9
 change.
 For removing " weight=10" and "\n", it's actually: 150 * 11 bytes = 1650
 bytes / 14603332 bytes binary size = 0.01% of binary size. (Those pesky
 decimals and megabytes!)

 Still, while we're changing the format, let's ditch the redundant weight
 line.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24679#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list