[tor-bugs] #24001 [Core Tor/Tor]: node_get_ed25519_id() should check if the microdesc ed25519 id is all zero
Tor Bug Tracker & Wiki
blackhole at torproject.org
Thu Dec 21 17:56:44 UTC 2017
#24001: node_get_ed25519_id() should check if the microdesc ed25519 id is all zero
--------------------------+------------------------------------
Reporter: teor | Owner: (none)
Type: defect | Status: needs_revision
Priority: Medium | Milestone: Tor: 0.3.3.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: easy intro | Actual Points:
Parent ID: #23975 | Points: 0.5
Reviewer: | Sponsor:
--------------------------+------------------------------------
Comment (by aruna1234):
Replying to [comment:8 teor]:
> That checks if the first byte of the object is zero. We need to check if
every byte is zero.
> We have a function for that, I think it's called tor_mem_is_zero().
I added this,
if(tor_mem_is_zero((char*)node->md,
sizeof(node->md->ed25519_identity_pkey)))
however it is failing when I do a make check at src/test/test.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24001#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list