[tor-bugs] #24666 [Core Tor/Tor]: sched: Store the circuit ID instead of the full DESTROY cell in the destroy queue

[Tor Bug Tracker & Wiki]

#24666: sched: Store the circuit ID instead of the full DESTROY cell in the destroy
queue
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  nickm
     Type:  defect                               |         Status:  closed
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tor-sched, tor-cell,                 |  Actual Points:
  backport-031,backport-030, backport-029,       |
  backport-028, backport-025                     |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => fixed


Comment:

 okay. I made a bug24666_squashed_025 branch, then merged it forward.

 Merge notes:
  * I added `cd1f708a7f44ab305c9fcda0060f55f075b98362` to free the destroy
 cell in the unit test more correctly. Otherwise, coverity would have
 complained that there were paths where it didn't get freed.
  * `7d845976e3897fac8e78a4a26688ac57b660151b` was a trivial merge conflict
 in the unit tests in 0.2.8.
  * `b8a3602b2a7114f2027d4a3af27520b109762efd` had a simple but nontrivial
 merge conflict in `channel_flush_from_first_active_circuit`.
  * We've changed the way that we handle timestamps twice since 0.2.5.  So
 in 0.2.9, I shifted the (as yet unused) timestamp to monotonic msec in
 `79a50afa0e3dd44fc5ef80806ccda501fab5a718`, and in 0.3.3 I shifted it to
 monotonic timestamp units in `1eeb505e6f08591c39e0a000efab3948ef1ef5b5`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24666#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online