[tor-bugs] #24665 [Core Tor/Tor]: sched: In KIST, the extra_space kernel value needs to be allowed to be negative

[Tor Bug Tracker & Wiki]

#24665: sched: In KIST, the extra_space kernel value needs to be allowed to be
negative
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_revision
 Priority:  Very High     |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.3.2.1-alpha
 Severity:  Normal        |     Resolution:
 Keywords:  tor-sched     |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by pastly):

 * status:  needs_review => needs_revision


Comment:

 I would change the following comment. Then it LGTM.

 {{{
 diff --git a/src/or/scheduler_kist.c b/src/or/scheduler_kist.c
 index 0bd51bed7..a50be345b 100644
 --- a/src/or/scheduler_kist.c
 +++ b/src/or/scheduler_kist.c
 @@ -266,8 +266,7 @@ update_socket_info_impl, (socket_table_ent_t *ent))

    /* These values from the kernel are uint32_t, they will always fit into
 a
     * int64_t tcp_space variable but if the congestion window cwnd is
 smaller
 -   * than the unacked packets, the remaining TCP space is set to 0 so we
 don't
 -   * write more on this channel. */
 +   * than the unacked packets, the remaining TCP space is set to 0. */
    if (ent->cwnd >= ent->unacked) {
      tcp_space = (ent->cwnd - ent->unacked) * (int64_t)(ent->mss);
    } else {
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24665#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online