[tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 20 16:30:06 UTC 2017


#24423: Fix STACK warnings in Tor
-----------------------------+------------------------------------
 Reporter:  nickm            |          Owner:  nickm
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  review-group-27  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  catalyst         |        Sponsor:
-----------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review


Comment:

 The test_channel_flushmux() test no longer exists in 0.3.3, since channel
 queues no longer exist. (See #23709.)

 If we want, we can remove all the redundant checks for whether
 new_fake_channel() has failed -- I have those in a branch called
 one_more_stack_fix, but I suggest that we don't actually take them, since
 these don't actually seem to cause stack warnings.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list