[tor-bugs] #23271 [Core Tor/Tor]: control_auth_cookie isn't deleted when tor stops

[Tor Bug Tracker & Wiki]

#23271: control_auth_cookie isn't deleted when tor stops
------------------------------+------------------------------------
 Reporter:  yurivict271       |          Owner:  (none)
     Type:  defect            |         Status:  merge_ready
 Priority:  Medium            |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor      |        Version:  Tor: 0.3.0.10
 Severity:  Normal            |     Resolution:
 Keywords:  easy tor-control  |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------------

Comment (by nickm):

 Do we have to check whether the file exists before removing it?  I'd
 suggest instead:

 {{{
 void
 tor_remove_file(const char *filename)
 {
   if (tor_unlink(filename) != 0 && errno != ENOENT) {
     log_warn(LD_FS, "Couldn't unlink %s: %s",
              filename, strerror(errno));
   }
 }
 }}}

 If that's okay with you, I'll merge it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23271#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online