[tor-bugs] #23989 [Core Tor/Tor]: entry_guards_update_all() will pretend to update primaries even if sampled set is empty

[Tor Bug Tracker & Wiki]

#23989: entry_guards_update_all() will pretend to update primaries even if sampled
set is empty
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  accepted
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-guard, tor-bridge, tor-client,   |  Actual Points:
  030-backport, 031-backport                     |
Parent ID:  #21969                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * milestone:  Tor: 0.3.2.x-final => Tor: 0.3.3.x-final


Comment:

 I think this might be something we could fix just by documentation -- the
 `primary_guards_up_to_date` flag now means "are the primary guards up-to-
 date with respect to the consensus and status info that we have" -- not
 necessarily "are the primary guards usable".  When
 primary_guards_up_to_date gets set with no consensus available, then
 calling update_primary_guards() again actually wouldn't be a good idea,
 since it wouldn't do anything.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23989#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online