[tor-bugs] #24633 [Core Tor/Tor]: to->pending->tqh_last is 0xFFFFFFFFFFFFFFFF。

[Tor Bug Tracker & Wiki]

#24633: to->pending->tqh_last is 0xFFFFFFFFFFFFFFFF。
-------------------------------------------------+-------------------------
 Reporter:  sx5486510                            |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  msvc 029-backport 030-backport       |  Actual Points:
  031-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  accepted => needs_review


Comment:

 If you can test (running the bitops tests and running tor) using the patch
 here, that would be confirmation that the approach works:

 {{{
 diff --git a/src/ext/timeouts/timeout-bitops.c b/src/ext/timeouts/timeout-
 bitops.c
 index a018f33b958500..45466f6cb313ca 100644
 --- a/src/ext/timeouts/timeout-bitops.c
 +++ b/src/ext/timeouts/timeout-bitops.c
 @@ -40,7 +40,7 @@ static __inline int clz32(unsigned long val)
  {
         DWORD zeros = 0;
         _BitScanReverse(&zeros, val);
 -       return zeros;
 +       return 31 - zeros;
  }
  #ifdef _WIN64
  /* According to the documentation, these only exist on Win64. */
 @@ -54,7 +54,7 @@ static __inline int clz64(uint64_t val)
  {
         DWORD zeros = 0;
         _BitScanReverse64(&zeros, val);
 -       return zeros;
 +       return 63 - zeros;
  }
  #else
  static __inline int ctz64(uint64_t val)
 }}}

 Also available in my public git repo in a branch called `bug24633_029`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24633#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online