[tor-bugs] #24637 [Obfuscation/BridgeDB]: moat: incorrect response if no bridges available

[Tor Bug Tracker & Wiki]

#24637: moat: incorrect response if no bridges available
----------------------------------+----------------------
 Reporter:  mcs                   |          Owner:  isis
     Type:  defect                |         Status:  new
 Priority:  Medium                |      Milestone:
Component:  Obfuscation/BridgeDB  |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:                        |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+----------------------

Comment (by mcs):

 Replying to [comment:1 isis]:
 > Thanks! I think the spec would probably be the better behaviour here?
 What do you think?

 Probably. Returning an error in this case makes it 100% clear that the
 request could not be fulfilled.

 > One quick question though: what if BridgeDB has 2 of the type requested,
 but not 3? (I.e. it's low on bridges) Should we just give the 2 that are
 useful and only return the JSON API 404 error if there's really no bridges
 at all?

 Is the Moat responder designed to return more than one bridge? The test
 server that Kathy and I compiled seems to always return just one. In fact,
 we currently have TODOs in the Tor Launcher code where we don't handle
 more than one bridge in the response (our code just grabs the first one in
 the array of returned bridges).

 If BridgeDB is going to return more than one bridge, I think we should
 just spec the protocol to allow for fewer then 3 to be returned. In other
 words, it is better to get back one bridge than none.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24637#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online