[tor-bugs] #13837 [Core Tor/Tor]: Mitigate guard discovery by pinning middle node

[Tor Bug Tracker & Wiki]

#13837: Mitigate guard discovery by pinning middle node
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, tor-guard, guard-discovery-  |  Actual Points:
  prop247-controller                             |
Parent ID:  #9001                                |         Points:
 Reviewer:  asn                                  |        Sponsor:
                                                 |  SponsorV-can
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 OK, fixes mostly look great! I went through all the #13837 discussion on
 gitlab and made sure everything is answered/addressed.

 Please see my branch `bug13837-rebased` for some doc fixes and
 simplifications (the branch is squashed as well).

 I encountered some annoying failures during testing this which I reported
 here:
 https://oniongit.eu/mikeperry/tor/commit/7e962536f2d89ab0e2b8dd8821503ed66bd115ac#note_1804

 I will continue testing this branch this week.

 I think the next step here is to squash the branch (including my fixes)
 and make an oniongit merge request for the squashed branch so that review
 can continue with Nick. I will also add any new issues I find during
 testing in the new oniongit merge request.

 Cheers!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13837#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online