[tor-bugs] #24175 [Metrics/Website]: Use an embedded Jetty in metrics-web and use metrics-base as build environment.

[Tor Bug Tracker & Wiki]

#24175: Use an embedded Jetty in metrics-web and use metrics-base as build
environment.
-----------------------------+--------------------------------
 Reporter:  iwakeh           |          Owner:  iwakeh
     Type:  enhancement      |         Status:  needs_revision
 Priority:  Medium           |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Thanks for splitting up that huge commit. These smaller commits are much
 easier to review!

 I made it through commits 8627a0a to 6b54501 in your task-24175-stepbystep
 branch and have a few remarks:

  - In e9b4bb5 you're moving the users-q-and-a.txt file, but you're not
 updating links in metrics.json. That's going to produce a couple dead
 links.
  - Commit 9a80a5b says it's a fixup for b17c1bf, but I believe it's rather
 a fixup for 2f5fd6f. And I believe it's an incomplete fixup commit,
 leaving some accidentally made changes unchanged. I haven't checked in
 detail.

 Those are the only findings from reading the diff. I might discover more
 issues while testing.

 How do we proceed? Do you mind if I make these remaining fixes while
 rebasing your branch to master? I'd then share the rebased branch here
 while testing it locally.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24175#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online