[tor-bugs] #24613 [Core Tor/Tor]: Avoid monotime_coarse_absolute_msec in channelpadding code

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Dec 14 21:31:52 UTC 2017


#24613: Avoid monotime_coarse_absolute_msec in channelpadding code
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor8-can
--------------------------+------------------------------------

Comment (by mikeperry):

 The netflow bits look good to me. The various platform-specific monotime
 diffs I am less confident about, but the unit tests look mostly convincing
 there. One potential improvemnt to the tests: add 1337 three times, so
 that we can also be sure that we properly overflow the internal sub-second
 values into a whole second on platforms that differentiate seconds and
 sub-seconds internally?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24613#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list